Found 2 in Faces Normal, one in the starting room and one in room 15105. See pic for error message. I tried to fix it, removing any extra carriage returns, but that didn't work.
It's not carriage returns that are the problem. It's when a line only has a carriage return and one or more spaces. I've finished my script - it can run against a whole directory full of mansions and identify the room number and object I'd of any problem areas. Also, Vern told me that the issue is fixed in his next update. I wonder if just identifying the problem areas is enough right now. I guess it will depend on what all is affected.
Also, I should point out that the problem is not limited to the end of the text. It can occur anywhere in the text. I created a small test mansion to test the various combinations.
I'll run my script tonight when I get home from work.
Well, when I cleaned up the signs so that there were no spaces with carriage returns, I still got the same error message. Maybe I missed something, who knows.
In Three Way Mansion, I had to clear the text, close and delete the sign, make a new sign and rewrite the text. Perhaps cut and paste will work (provided a new sign is made) in some cases.
It seems to me that this may be a problem in many of the older mansions, expecially in those where the sign texts were made with resource editors.
I'm not sure how much effort we should put into fixing all signs now. As I said in another post we could fix the signs one by one when we get complains from players. But it is up to you to decide.
70464E4A0E6D42574A5546230 wrote: Well, when I cleaned up the signs so that there were no spaces with carriage returns, I still got the same error message. Maybe I missed something, who knows.
Did you clean it with the editor? Do you still have a copy of the one reporting errors? If so, could you email it to me?
6C7C6B62620E0 wrote: In Three Way Mansion, I had to clear the text, close and delete the sign, make a new sign and rewrite the text. Perhaps cut and paste will work (provided a new sign is made) in some cases.
It seems to me that this may be a problem in many of the older mansions, expecially in those where the sign texts were made with resource editors.
I'm not sure how much effort we should put into fixing all signs now. As I said in another post we could fix the signs one by one when we get complains from players. But it is up to you to decide.
I definitely agree about not investing a lot of effort into it. I want to see what output the script generates. It should only rake a minute or two to scan all the mansions. If there's a lot, we could make the info available with word that the problem should be resolved with Vern's next release.
If it's not so widespread (I think this is unlikely - then again, many mansions have few to no signs) then perhaps we can reconsider what to do - it would be very easy for the same script to be modified to fix the issue as well. Unless there's more to it than I think, which is definitely possible.
03353D397D1E3124392635500 wrote: Decided to start a new topic to make it easier:
Found 2 in Faces Normal, one in the starting room and one in room 15105. See pic for error message. I tried to fix it, removing any extra carriage returns, but that didn't work.
The problem in Faces is that it was put in the wrong section. It didn't convert cleanly. Two rooms in both of the FACES mansions contained a sign that looked as though it was created with a resource editor. The name attribute of the TEXT resource contained information that was added to the file name.
Under the 'TEXT' directory for FACES exp Normal, there were two files:
00128
BBB Blue Doors
.txt
00129
BBB 1
.txt
The name attribute that is typically not set, is being added (in the quotes). If the files are renamed:
00128.txt
00129.txt
They work fine. I accidentally left that step out of the conversion process for FACES. This was also the case for Three Way Mansion. After running it through Rezycle, this is what is in the 'TEXT' directory:
The problem is not nearly as widespread as I'd been afraid of. This contains all the mansions I've run my script against so far:
These mansions have (had?) signs that have the CR issue:
(and have been verified)
* Art Minds Mansion
+ -- Room: [01406] contains a sign [id: 1941] with bad data[00215.txt]!
* Jacque's Revenge - Part 1 (checked 116 signs)
+ -- Room: [15337] contains a sign [id: 10391] with bad data[00286.txt]!
+ -- Room: [16304] contains a sign [id: 9434] with bad data[00239.txt]!
+ -- Room: [16314] contains a sign [id: 10285] with bad data[00281.txt]!
* Jacque's Revenge - Part 2 (checked 96 signs)
+ -- Room: [15910] contains a sign [id: 9188] with bad data[00246.txt]!
These were scanned by script and no problems were found - some required post
conversion modifications.
A Curious Observatory (11 signs)
Back to Square One (3 signs)
Bobcat Mansion Easy (1 sign)
Bobcat Mansion Normal (1 sign)
Catacombs (23 signs)
Cheetah Castle Easy (1 sign)
Cheetah Castle Normal (3 signs)
Daedalus (13 signs)
Doctor Tronic's Zoo (18 signs)
Doctor Tronic's Zoo Normal (19 signs)
Doldrum Dungeon (1 sign)
Dreamland (3 signs)
Eavesdropping (6 signs)
FACES exp Hard (2 signs) -- (after conversion issue fixed)
FACES exp Normal (2 signs) -- (after conversion issue fixed)
Foggy Forest Mansion (16 signs)
Gomorrah (12 signs)
Happy Hannukah! (2 signs)
Jack Visits His Neighbors (1 sign)
Jack in Spider World (8 signs)
Jack's BFF (23 signs)
Journey To Sarkozyland (8 signs)
Korvak's Keep (1 sign)
La Luna Mansion (17 signs)
The Mansion Family - MindMines (6 signs)
Midnight Castle (2 signs)
Midnight Mazes and Monsters (26 signs)
Midnight Pyramid (14 signs)
Mikee's Castle (2 signs)
Monty's Mansion (3 signs)
Octopus Mansion (7 signs)
Octopus Mansion Hard (18 signs)
otg Alpha Mansion (2 signs)
PACI-FREAK EXPRESS (6 signs)
Palais Pompomrouge (117 signs - 1 empty)
Palais Pompomrouge easy (117 signs - 1 empty)
Scorpion Mansion (1 sign)
Skeleton Mansion (18 signs)
Temple of Hallowe'en (6 signs)
Temple of the Gorgons (15 signs)
Temple of the Moon (1 sign)
The 7th Key (1 sign)
Three Way Mansion (5 signs) -- after conversion issue fixed
Tower of Power (1 sign)
Triad (4 sign)
Veronika's Ladders (10 signs)
Veronika's Towers (37 signs)
Don't have any signs (or at least no TEXT resources):
* Arevn's Mansion
* The Bat House
* Bedlam
* Creepy Cottage
* The Dalton Brothers
* Doppelganger Challenge
* The Dragon's Trap Hard
* The Dragon's Trap Normal
* Echo Keep
* Goblin's Lair
* Happy Christmas Jack Malone!
* Helter Skullter
* Helter Skullter Easy
* House of Wonders
* Knu's Infinite
* Landlord's Pub
* The Launcher (bundled w/ The Mall)
* The Lost Jungle
* The Lost Jungle 2
* The Mall
* Malone Manor
* Matt & Joe's Intro
* Matt & Joe's Place
* Mini Ore Mine
* This Old Mansion
* One Room
* Orpheus
* Palace of Gore
* Sky Boxes
* Small Palace of Gore
* The Swiss Mansion Easy
* The Swiss Mansion Hard
* The Swiss Mansion Normal
* The Turtle Mansion
No signs, but orphaned TEXT resources
* A Deserted Holiday Village
* Starter Home
* The Warrior
All these mansions were in one directory, and I ran the script against all of them. It took a minute or two. I'll add more mansions to the list as I see what's missing.